Skip to content

Remove uncurried chapter and update existing docs to uncurried #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 15, 2023
Merged

Remove uncurried chapter and update existing docs to uncurried #750

merged 3 commits into from
Nov 15, 2023

Conversation

fhammerschmidt
Copy link
Member

@fhammerschmidt fhammerschmidt commented Nov 14, 2023 •
edited
Loading

Also removed a lot of final units in example code.

ryyppy
ryyppy requested changes Nov 15, 2023
View reviewed changes
Copy link
Member

@ryyppy ryyppy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments / nitpicks. But generally, looking great!

pages/docs/manual/latest/build-configuration.mdx
- `".bs.mjs"`
- `".bs.cjs"`

Currently prefer `.bs.js` for now.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this... is this somewhat possible to fix? @cknitt @cristianoc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the main concern was mostly about genType relying on bs.js when I am not mistaken? Nowadays genType reads the rescript.json anyways, so I assume some constraints regarding configuring the .js extension should be lifted?

ryyppy
ryyppy approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@ryyppy ryyppy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only question I have is how we treat the (.) => {} syntax in the docs.

As I understand, everything is now an uncurried function. But at some point ppl will see the syntax and wonder what it is.

@fhammerschmidt fhammerschmidt merged commit 4d7cc30 into rescript-11 Nov 15, 2023
@fhammerschmidt fhammerschmidt deleted the uncurried-docs branch November 15, 2023 22:09
@fhammerschmidt
Copy link
Member Author

Suggestion:

fhammerschmidt added a commit to fhammerschmidt/rescript-lang.org that referenced this pull request Dec 5, 2023
@fhammerschmidt
WIP: 4d7cc30 Merge pull request rescript-lang#750 from rescript-assoc…
0814bdf 
…iation/uncurried-docs
fhammerschmidt added a commit to fhammerschmidt/rescript-lang.org that referenced this pull request Dec 5, 2023
@fhammerschmidt
WIP: 4d7cc30 Merge pull request rescript-lang#750 from rescript-assoc…
a0a2963 
…iation/uncurried-docs
fhammerschmidt added a commit to fhammerschmidt/rescript-lang.org that referenced this pull request Dec 27, 2023
@fhammerschmidt
WIP: 4d7cc30 Merge pull request rescript-lang#750 from rescript-assoc…
83650e9 
…iation/uncurried-docs
fhammerschmidt added a commit to fhammerschmidt/rescript-lang.org that referenced this pull request Jan 12, 2024
@fhammerschmidt
WIP: 4d7cc30 Merge pull request rescript-lang#750 from rescript-assoc…
dd65d81 
…iation/uncurried-docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryyppy ryyppy ryyppy approved these changes

@zth zth zth approved these changes

@cristianoc cristianoc Awaiting requested review from cristianoc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fhammerschmidt @ryyppy @zth